Add crossOrigin option for WMS layer #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmomtchev are those tests failing because of that change here? what am i missing here? |
|
Can you add debug to rlayers/test/RLayerMisc.test.tsx Line 19 in 3c9e715 Github Actions prevent the sharing of secrets across repositories and I wonder what is the state of this variable on your side? It seems that it is not empty, yet there is no secret. |
Seems like it worked! Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently WMS layer is missing crossOrigin option.
Personally i need it to make screenshot out of wms layer aka export it.
fixes that issue here: #156