Remove unnecessary fmt package & remove sentry_sentry auth arg #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, nice to see some activity in this repository!
I'm back again with another PR.
Marshal had the bright idea to
:nicknames
one of its packagesfmt
, which conflicts with thefmt
package this library requires, so I replacedfmt
with aformat
. Since thefmt
library is only used once (to format that Auth header) and I think my suggested replacement is a bit more readable (maybe not the control-string tho :p), I removed the:depends-on
as well in the asd-file.Additionally, Sentry SDK - Authentication states
sentry_secret
to be effectively deprecated, so I removed it in the same commit from the Auth header since there's nosentry_secret
referenced anywhere anymore. Also, the resulting value ofsentry_secret
would end up beingNIL
, which the docs whine about:Lastly, an unrelated matter: I noticed
sentry_version=5
, while the docs state thesentry_version
to be 7. My search efforts could not determine whether it affects anything, so I'm just giving a heads-up. Maybe you know if its wanted or not.Thanks