Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary fmt package & remove sentry_sentry auth arg #6

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

jmeissen
Copy link
Contributor

Hello, nice to see some activity in this repository!

I'm back again with another PR.

Marshal had the bright idea to :nicknames one of its packages fmt, which conflicts with the fmt package this library requires, so I replaced fmt with a format. Since the fmt library is only used once (to format that Auth header) and I think my suggested replacement is a bit more readable (maybe not the control-string tho :p), I removed the :depends-on as well in the asd-file.

Additionally, Sentry SDK - Authentication states sentry_secret to be effectively deprecated, so I removed it in the same commit from the Auth header since there's no sentry_secret referenced anywhere anymore. Also, the resulting value of sentry_secret would end up being NIL, which the docs whine about:

The sentry_secret must only be included if a secret key portion was contained in the DSN.

Lastly, an unrelated matter: I noticed sentry_version=5, while the docs state the sentry_version to be 7. My search efforts could not determine whether it affects anything, so I'm just giving a heads-up. Maybe you know if its wanted or not.

Thanks

@mmontone mmontone merged commit dd5a98b into mmontone:master Sep 28, 2022
@mmontone
Copy link
Owner

Thanks. I'm merging your pull request.

I know nothing about the sentry_version thing :)

@jmeissen jmeissen deleted the delete-fmt branch September 28, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants