Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Notify the user when using the python-language-server backend #22

Closed
wants to merge 1 commit into from

Conversation

guillaumealgis
Copy link
Contributor

@guillaumealgis guillaumealgis commented Dec 5, 2021

As discussed in #18, this adds a notification to the user when using the python-language-server package as a LSP server, instead of the more recent and maintained python-lsp-server.

Capture d’écran 2021-12-05 à 23 21 59

  • If clicking "Ignore", the notification will disappear and never be displayed again until the pyls.executable preference changes (allowing the users to keep using python-language-server if they choose to, without being bothered again in the future)
  • If clicking "More info" a more details page of explanations is opened in a browser, currently the URL opened is Migrate to python-lsp-server ? #18, but we could change it for something more detailed, like a wiki page for example
  • "OK" only dismisses the notification, but it will be shown again the next time the LSP server is started

This is a draft, because:

  1. This PR builds upon Migrate to python-lsp-server ? #18, so Migrate to python-lsp-server ? #18 needs to be merged before we can apply this
  2. The "More info" URL and its content must be validated.

@mmshivesh
Copy link
Owner

mmshivesh commented Mar 15, 2022

I'm going ahead and merging this if there's been no issues so far.

@guillaumealgis guillaumealgis deleted the pyls-alert branch November 19, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants