This repository has been archived by the owner on May 19, 2022. It is now read-only.
Do not require symlinks to resolve #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add --version cli flag
Allow package variants with different metadata
Remove unnecessary field from variant PR
Fail on unknown fields in `package.metadata.deb`
Add support for the 'Recommends' manifest field.
There's no difference on smaller binaries, since they don't get spread across multiple lzma blocks to have anything to parallelize, but for bigger binaries with many dependencies there's a noticeable win. Below are the numbers from embedding 100MB of `/dev/urandom` into `cargo-deb` itself and running it on my Macbook Air with M1 processor. * Fast mode ``` real 0m3.597s user 0m24.262s sys 0m0.265s ``` * Regular mode: ``` real 0m9.833s user 0m37.334s sys 0m0.529s ```
Enable parallel xz compression out of the box
As reported here: nickbabcock/dness#278 installing a package with relative paths will fail on ubuntu 21.04 with the following error message ``` dpkg: error processing archive latest.deb (--install): conffile name 'etc/dness/dness.conf' is not an absolute pathname ``` This appears to be a relative recent change to dpkg: https://www.mail-archive.com/debian-dpkg-cvs@lists.debian.org/msg07446.html This commit changes all references that are relative paths to absolute paths.
Prefer absolute paths for latest compatibility
If preserve-symlinks is enabled then symlinks don't have to resolve to be added to the package. This is e.g. useful for aliases for executables.
|
I would prefer to minimize amount of configuration options users need to know about. Would it be possible to have some smart defaults for this? For example, if symlink resolves to a file, then copy the file. If the symlink is "broken", then copy the symlink itself (possibly with a warning that suggests setting the config flag to silence the warning). |
|
Hm. That's a bit tricky because it means the behavior changes if the symlink starts resolving. Maybe it should still be an error, just a more informative one with that same suggestion? |
|
Yeah, but what are the chances that it will start resolving? Error with help text is a good idea. |
kornelski
suggested changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If preserve-symlinks is enabled then symlinks don't have to resolve to be added to the package. This is e.g. useful for aliases for executables, where the symlink is in a different directory before being copied.