Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few places where GC static analyzer will report as errors #46

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix a few places where GC static analyzer will report as errors #46

merged 1 commit into from
Apr 23, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Apr 23, 2024

These functions do not include GC safe points. But without marking them as JL_NOTSAFEPOINT, the GC checker will report errors in other places.

@qinsoon qinsoon requested a review from udesou April 23, 2024 05:02
udesou
udesou reviewed Apr 23, 2024
View reviewed changes
Copy link

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Interesting that you need to annotate both the declaration and implementation. I see that in gc-common.c, for example, the implementation of jl_array_nbytes already has the annotation.

@udesou udesou self-requested a review April 23, 2024 07:00
@qinsoon qinsoon merged commit 7de6269 into mmtk:v1.9.2+RAI Apr 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udesou udesou udesou approved these changes

Assignees
No one assigned
Labels
port-to-master port-to-v1.9 port-to-v1.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinsoon @udesou