Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static analyzer to check pinning state #49

Merged
merged 10 commits into from
May 16, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented May 14, 2024

This PR introduces some preliminary work to use GCChecker to check pinning state. The clangsa tests pass. But the checker found issues with the current runtime code base. Future PRs will fix that.

@qinsoon
Copy link
Member Author

qinsoon commented May 16, 2024

@udesou To run the checker on moma machines, you will need to change the following line in Make.inc. Comment out the following line,

CLANGSA_CXXFLAGS += --gcc-toolchain="$(abspath $(shell LANG=C $(CC) -print-search-dirs | grep '^install: ' | sed -e "s/^install: //")/../../../..)"

and use this instead:

CLANGSA_CXXFLAGS += --gcc-toolchain="/usr/lib/gcc/x86_64-linux-gnu/11" -I/usr/include/x86_64-linux-gnu/c++/11 -I/usr/include/c++/11 -D__STDCPP_WANT_MATH_SPEC_FUNCS__=1

@qinsoon qinsoon marked this pull request as ready for review May 16, 2024 02:14
@qinsoon qinsoon requested a review from udesou May 16, 2024 02:14
Copy link

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look at the changes in all files and they all look good to me. For the code in GCChecker.cpp, I think I'd have to have a proper look to understand what is going on there to suggest any changes. Hopefully we can capture possible bugs when running the checker and it can be reviewed by one of the Julia guys down the line. For now, it LGTM.

@qinsoon qinsoon merged commit b1f61bb into mmtk:v1.9.2+RAI May 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants