-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static analyzer to check pinning state #49
Conversation
JL_GLOBALLY_PINNED/TPINNED
acf3a25
to
02e5521
Compare
@udesou To run the checker on moma machines, you will need to change the following line in
and use this instead:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick look at the changes in all files and they all look good to me. For the code in GCChecker.cpp
, I think I'd have to have a proper look to understand what is going on there to suggest any changes. Hopefully we can capture possible bugs when running the checker and it can be reviewed by one of the Julia guys down the line. For now, it LGTM.
This PR introduces some preliminary work to use GCChecker to check pinning state. The clangsa tests pass. But the checker found issues with the current runtime code base. Future PRs will fix that.