Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding perf compare CI is broken #906

Closed
caizixian opened this issue Aug 16, 2023 · 1 comment · Fixed by #1005
Closed

Binding perf compare CI is broken #906

caizixian opened this issue Aug 16, 2023 · 1 comment · Fixed by #1005
Labels
P-CRITICAL Priority: Critical. A critical issue should be prioritized and fixed immediately.

Comments

@caizixian
Copy link
Member

For example, https://github.com/mmtk/mmtk-core/actions/runs/5877259952
@wks wks added the P-CRITICAL Priority: Critical. A critical issue should be prioritized and fixed immediately. label Oct 30, 2023
@caizixian caizixian linked a pull request Oct 31, 2023 that will close this issue
Use new running scripts in ci-perf-kit #1005
Merged
@qinsoon qinsoon mentioned this issue Nov 2, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 3, 2023
@qinsoon
Use new running scripts in ci-perf-kit (#1005)
dad49c2 
This PR updates to ci-perf-kit 0.7.0. It fixes a few issues:
* Use new running scripts: #980
* Run all the benchmarks for all the plans:
#981
* Perf comparison for PR works again:
#906
@qinsoon
Copy link
Member

qinsoon commented Nov 4, 2023

The perf compare CI is working. It needs to be manually triggered in actions: https://github.com/mmtk/mmtk-core/actions/workflows/perf-compare-ci.yml

This issue #282 talks about better presentation of the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-CRITICAL Priority: Critical. A critical issue should be prioritized and fixed immediately.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new running scripts in ci-perf-kit mmtk/mmtk-core
3 participants
@wks @qinsoon @caizixian