Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_gc_trigger() for LockFreeImmortalSpace #1003

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Implement get_gc_trigger() for LockFreeImmortalSpace #1003

merged 3 commits into from
Oct 31, 2023

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Oct 30, 2023 •
edited
Loading

This PR fixes two issues in LockFreeImmortalSpace and adds a test.

@qinsoon qinsoon requested a review from wks October 30, 2023 06:28
wks
wks approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon enabled auto-merge October 31, 2023 07:05
@qinsoon qinsoon added this pull request to the merge queue Oct 31, 2023
Merged via the queue into mmtk:master with commit 91191be Oct 31, 2023
19 checks passed
@qinsoon qinsoon deleted the fix-lockfree-immortalspace branch October 31, 2023 08:46
@qinsoon qinsoon mentioned this pull request Nov 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LockFreeImmortalSpace should not assume it can use the whole heap range
2 participants
@qinsoon @wks