Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby binding test repo checkout #1048

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

wks
Copy link
Collaborator

@wks wks commented Dec 14, 2023

The Ruby binding test now checks out the revision of the ruby repo selected in mmtk-ruby/mmtk/Cargo.toml instead of the latest revision.

The Ruby binding test now checks out the revision of the `ruby` repo
selected in `mmtk-ruby/mmtk/Cargo.toml` instead of the latest revision.
@wks wks added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label Dec 14, 2023
@wks wks requested a review from k-sareen December 14, 2023 06:37
Copy link
Collaborator

@k-sareen k-sareen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@k-sareen k-sareen added this pull request to the merge queue Dec 14, 2023
@tianleq tianleq self-requested a review December 14, 2023 06:49
Merged via the queue into mmtk:master with commit bf1bad3 Dec 14, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants