Fix un-cleared VO bits for contiguous monotone PR #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug that when using a generational plan, if mutators allocated less than one chunk of memory into the nursery between GCs, some VO bits will not be cleared. This PR also ensures the field `MonotonePageResourceSync::current_chunk` grows monotonically during GC when the space is contiguous.
qinsoon
added
the
PR-testing
|
The JikesRVM test failed, due to an issue for downloading classpath from its FTP server. It should be unrelated with the change. I will see if we can work around it. I also noticed a random failure for Ruby tests (see run attempt 3). It is probably unrelated as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that when using a generational plan, if mutators allocated less than one chunk of memory into the nursery between GCs, some VO bits will not be cleared.
This PR also ensures the field
MonotonePageResourceSync::current_chunkgrows monotonically during GC when the space is contiguous.Fixes: #1070