Fix warnings with the stable Rust toolchain #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As getting a ref `&` of `static mut` variables will become a compilation
error in the Rust 2024 Edition, we use `unsafe { &*addr_of!(VM_LAYOUT)
}` to work around it.
See: mmtk#1098
Changed the `static mut` in mock_test_doc_avoid_resolving_allocator.rs
to an ordinary local variable.
Initialize the thread-local variable `WORKER_ORDINAL` with a `const`
block. It avoids lazy initialization. We also bumped the
`rust-version` field in Cargo.toml to 1.71.1 because the semantics of
the `const` block in the `thread_local!` macro was undocumented in
1.70.0.
wks
changed the title
qinsoon
reviewed
Mar 25, 2024
| @@ -10,7 +10,7 @@ repository = "https://github.com/mmtk/mmtk-core" | |||
| readme = "README.md" | |||
| categories = ["memory-management"] | |||
| keywords = ["gc", "garbage", "collection", "garbage-collection", "allocation"] | |||
| rust-version = "1.70.0" | |||
| rust-version = "1.71.1" | |||
There was a problem hiding this comment.
This breaks our MSRV policy. Our pinned Rust version is 1.71.1 and the MSRV should be at max 1.70. We can think about bumping our pinned version (to 1.77).
There was a problem hiding this comment.
I bumped rust-toolchain to 1.77.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As getting a ref
&ofstatic mutvariables will become a compilation error in the Rust 2024 Edition, we useunsafe { &*addr_of!(VM_LAYOUT) }to work around it. See: #1098Changed the
static mutin mock_test_doc_avoid_resolving_allocator.rs to an ordinary local variable.Initialize the thread-local variable
WORKER_ORDINALwith aconstblock. It avoids lazy initialization. We also bumped therust-versionfield in Cargo.toml to 1.71.1 because the semantics of theconstblock in thethread_local!macro was undocumented in 1.70.0.