Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the openjdk test name in merge check #1119

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Apr 17, 2024

The extended tests for OpenJDK reuses a workflow, so its action name is different. We did not use the correct action name since #1073. It manifested as the merge check was waiting for the OpenJDK tests to finish and checked its result before it finished.

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Apr 17, 2024
@qinsoon qinsoon requested a review from wks April 17, 2024 03:00
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added this pull request to the merge queue Apr 17, 2024
Merged via the queue into mmtk:master with commit fc35498 Apr 17, 2024
30 checks passed
@qinsoon qinsoon deleted the fix-openjdk-tests-name-in-merge-check branch April 17, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants