Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mark bit clearing in PrepareChunkMap #1148

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

wks
Copy link
Collaborator

@wks wks commented Jun 11, 2024

Each PrepareChunkMap work packet (used by native MS) should only clear the side mark bits of the single chunk it is responsible for.

Fixes: #1144

Each PrepareChunkMap work packet (used by native MS) should only clear
the side mark bits of the single chunk it is responsible for.

Fixes: mmtk#1144
@wks wks requested a review from qinsoon June 11, 2024 09:21
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wks
Copy link
Collaborator Author

wks commented Jun 11, 2024

The broken link is a remnant from the previous PR, at which time we removed docs/header/mmtk.h. I'll make another PR to fix the link.

@wks wks added this pull request to the merge queue Jun 11, 2024
Merged via the queue into mmtk:master with commit 1cf2805 Jun 11, 2024
23 of 24 checks passed
@wks wks deleted the fix/ms-clear-mark branch June 11, 2024 12:52
k-sareen pushed a commit to k-sareen/mmtk-core that referenced this pull request Jan 3, 2025
Each PrepareChunkMap work packet (used by native MS) should only clear
the side mark bits of the single chunk it is responsible for.

Fixes: mmtk#1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PrepareChunkMap (mark-sweep) unnecessarily clearing mark bits of all chunks
2 participants