-
Notifications
You must be signed in to change notification settings - Fork 77
Manual dispatch perf compare #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
596c3e2
Separate performance tests from correctness tests for bindings. Disable
qinsoon 04bfc37
Change perf-compare-ci to manually dispatch
qinsoon 5a9a394
Test perf compare
qinsoon 4b86139
Remove the label check
qinsoon 89c183b
Remove the acutal run for OpenJDK
qinsoon ea4980d
Revert some test changes.
qinsoon 44288eb
Update .github/workflows/perf-compare-ci.yml
caizixian 7dd5ac6
Merge branch 'master' into manual-dispatch-perf-compare
qinsoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,216 @@ | ||
name: Binding Perf Tests | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
pull_request: | ||
description: The pull request number to run the perf tests. The workflow compares the specified pull request with the trunk. | ||
required: true | ||
|
||
jobs: | ||
jikesrvm-perf-compare: | ||
runs-on: [self-hosted, Linux, freq-scaling-off] | ||
steps: | ||
- run: echo "PERF_PR=${{ github.event.inputs.pull_request }}" >> $GITHUB_ENV | ||
- name: Check Revisions | ||
uses: qinsoon/comment-env-vars@1.1.0 | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
pull_request: ${{ env.PERF_PR }} | ||
default_env: 'JIKESRVM_BINDING_TRUNK_REF=master,MMTK_CORE_TRUNK_REF=master,JIKESRVM_BINDING_BRANCH_REF=master,MMTK_CORE_BRANCH_REF=${{ github.event.pull_request.head.sha }}' | ||
# Trunk | ||
# - binding | ||
- name: Checkout JikesRVM Binding Trunk | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: mmtk/mmtk-jikesrvm | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
path: mmtk-jikesrvm-trunk | ||
submodules: true | ||
ref: ${{ env.JIKESRVM_BINDING_TRUNK_REF }} | ||
# - core | ||
- name: Checkout MMTk Core | ||
uses: actions/checkout@v2 | ||
with: | ||
ref: ${{ env.MMTK_CORE_TRUNK_REF }} | ||
path: mmtk-core-trunk | ||
# Branch | ||
# - binding | ||
- name: Checkout JikesRVM Binding Branch | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: mmtk/mmtk-jikesrvm | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
path: mmtk-jikesrvm-branch | ||
submodules: true | ||
ref: ${{ env.JIKESRVM_BINDING_BRANCH_REF }} | ||
# - core | ||
- name: Checkout MMTk Core | ||
uses: actions/checkout@v2 | ||
with: | ||
ref: ${{ env.MMTK_CORE_BRANCH_REF }} | ||
path: mmtk-core-branch | ||
# Checkout perf-kit | ||
- name: Checkout Perf Kit | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: mmtk/ci-perf-kit | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
ref: "0.6.5" | ||
path: ci-perf-kit | ||
submodules: true | ||
# setup | ||
# Use rust-toolchain in the trunk (it doesnt matter much - if the toolchains defined in the trunk and the branch are different, we cant run anyway) | ||
- name: Setup Rust Toolchain | ||
run: echo "RUSTUP_TOOLCHAIN=`cat mmtk-core-trunk/rust-toolchain`" >> $GITHUB_ENV | ||
- name: Setup | ||
run: | | ||
mkdir -p ci-perf-kit/running/benchmarks/dacapo | ||
cp /usr/share/benchmarks/dacapo/dacapo-2006-10-MR2.jar ci-perf-kit/running/benchmarks/dacapo/ | ||
# run compare | ||
- uses: hasura/comment-progress@v2.1.0 | ||
with: | ||
github-token: ${{ secrets.CI_ACCESS_TOKEN }} | ||
repository: 'mmtk/mmtk-core' | ||
number: ${{ env.PERF_PR }} | ||
id: jikesrvm-perf-compare-comment | ||
message: 'Running benchmarks for JikesRVM...' | ||
recreate: true | ||
- name: Compare Performance | ||
id: run | ||
run: | | ||
JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64 ./ci-perf-kit/scripts/jikesrvm-compare.sh mmtk-jikesrvm-trunk/ mmtk-core-trunk/ mmtk-jikesrvm-branch/ mmtk-core-branch/ jikesrvm-compare-report.md | ||
# set report.md to output | ||
- uses: pCYSl5EDgo/cat@master | ||
id: cat | ||
with: | ||
path: jikesrvm-compare-report.md | ||
# upload run results | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: jikesrvm-log | ||
path: ci-perf-kit/running/results/log | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: jikesrvm-compare-report.md | ||
path: jikesrvm-compare-report.md | ||
# report | ||
- uses: hasura/comment-progress@v2.1.0 | ||
if: always() | ||
with: | ||
github-token: ${{ secrets.CI_ACCESS_TOKEN }} | ||
repository: 'mmtk/mmtk-core' | ||
number: ${{ env.PERF_PR }} | ||
id: jikesrvm-perf-compare-comment | ||
message: ${{ steps.cat.outputs.text }} | ||
append: true | ||
# Cleanup logs (this is necessary for self-hosted runners) | ||
caizixian marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# [`always()`](https://docs.github.com/en/actions/reference/context-and-expression-syntax-for-github-actions#always) ensures we clean up the logs even if some steps fail | ||
- name: Clean up logs and reports | ||
if: always() | ||
run: | | ||
rm -rf ci-perf-kit/running/results/log/* | ||
rm jikesrvm-compare-report.md | ||
|
||
openjdk-perf-compare: | ||
runs-on: [self-hosted, Linux, freq-scaling-off] | ||
steps: | ||
- run: echo "PERF_PR=${{ github.event.inputs.pull_request }}" >> $GITHUB_ENV | ||
- name: Check Revisions | ||
uses: qinsoon/comment-env-vars@1.1.0 | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
pull_request: ${{ env.PERF_PR }} | ||
default_env: 'OPENJDK_BINDING_TRUNK_REF=master,MMTK_CORE_TRUNK_REF=master,OPENJDK_BINDING_BRANCH_REF=master,MMTK_CORE_BRANCH_REF=${{ github.event.pull_request.head.sha }}' | ||
# Trunk | ||
# - binding | ||
- name: Checkout OpenJDK Binding Trunk | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: mmtk/mmtk-openjdk | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
path: mmtk-openjdk-trunk | ||
submodules: true | ||
ref: ${{ env.OPENJDK_BINDING_TRUNK_REF }} | ||
# -core | ||
- name: Checkout MMTk Core | ||
uses: actions/checkout@v2 | ||
with: | ||
ref: ${{ env.MMTK_CORE_TRUNK_REF }} | ||
path: mmtk-core-trunk | ||
# Branch | ||
# - binding | ||
- name: Checkout OpenJDK Binding Branch | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: mmtk/mmtk-openjdk | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
path: mmtk-openjdk-branch | ||
submodules: true | ||
ref: ${{ env.OPENJDK_BINDING_BRANCH_REF }} | ||
# - core | ||
- name: Checkout MMTk Core | ||
uses: actions/checkout@v2 | ||
with: | ||
ref: ${{ env.MMTK_CORE_BRANCH_REF }} | ||
path: mmtk-core-branch | ||
# checkout perf-kit | ||
- name: Checkout Perf Kit | ||
uses: actions/checkout@v2 | ||
with: | ||
repository: mmtk/ci-perf-kit | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
ref: "0.6.5" | ||
path: ci-perf-kit | ||
submodules: true | ||
# setup | ||
# Use rust-toolchain in the trunk (it doesnt matter much - if the toolchains defined in the trunk and the branch are different, we cant run anyway) | ||
- name: Setup Rust Toolchain | ||
run: echo "RUSTUP_TOOLCHAIN=`cat mmtk-core-trunk/rust-toolchain`" >> $GITHUB_ENV | ||
- name: Setup | ||
run: | | ||
mkdir -p ci-perf-kit/running/benchmarks/dacapo | ||
cp /usr/share/benchmarks/dacapo/dacapo-2006-10-MR2.jar ci-perf-kit/running/benchmarks/dacapo/ | ||
# run compare | ||
- uses: hasura/comment-progress@v2.1.0 | ||
with: | ||
github-token: ${{ secrets.CI_ACCESS_TOKEN }} | ||
repository: 'mmtk/mmtk-core' | ||
number: ${{ env.PERF_PR }} | ||
id: openjdk-perf-compare-comment | ||
message: 'Running benchmarks for OpenJDK...' | ||
recreate: true | ||
- name: Compare Performance | ||
id: run | ||
run: | | ||
./ci-perf-kit/scripts/openjdk-compare.sh mmtk-openjdk-trunk/ mmtk-core-trunk/ mmtk-openjdk-branch/ mmtk-core-branch/ openjdk-compare-report.md | ||
# set report.md to output | ||
- uses: pCYSl5EDgo/cat@master | ||
id: cat | ||
with: | ||
path: openjdk-compare-report.md | ||
# upload run results | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: openjdk-log | ||
path: ci-perf-kit/running/results/log | ||
- uses: actions/upload-artifact@v2 | ||
with: | ||
name: openjdk-compare-report.md | ||
path: openjdk-compare-report.md | ||
# report | ||
- uses: hasura/comment-progress@v2.1.0 | ||
if: always() | ||
with: | ||
github-token: ${{ secrets.CI_ACCESS_TOKEN }} | ||
repository: 'mmtk/mmtk-core' | ||
number: ${{ env.PERF_PR }} | ||
id: openjdk-perf-compare-comment | ||
message: ${{ steps.cat.outputs.text }} | ||
append: true | ||
# Cleanup logs (this is necessary for self-hosted runners) | ||
- name: Clean up logs and reports | ||
if: always() | ||
run: | | ||
rm -rf ci-perf-kit/running/results/log/* | ||
rm openjdk-compare-report.md |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.