Introduce a context object for GC controller thread #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `GCController` struct. It is owned by the GC controller thread. It owns the `GCWorker` for the controller, and has references to objects that it needs to communicate with other threads. Previously, those dependencies were scattered in `ControllerCollectorContext` and `GCWorkScheduler`, which complicated the initialization of the MMTk instance and the GC controller thread.
Move the GCWorkScheduler::wait_for_completion method to the GCController type. This allows us to move controller-specific fields away from GCWorkScheduler, too.
qinsoon
reviewed
Jan 31, 2022
- Renamed ControllerCollectorContext to GCRequester - Removed initializer and finalizer functions from GCWorkScheduler - The embedded GCController is no longer boxed. - Added comments - Minor adjustment to API functions. - Other minor fixes.
|
@qinsoon I made changes according to your suggestions. I set this PR to be ready for review. When I was reading the code of |
|
Binding updates for this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of a series of planned changes to refactor the scheduler. The problems are described in issue #532
This PR introduces the
GCControllerstruct. LikeGCWorker, aGCControllershall be owned by the GC controller thread. It owns itsGCWorker(thecoordinator_worker) and the receiving end of the worker-to-controller channel. It also has references to the data structures it needs to work with, including the scheduler and theControllerCollectorContextwhich is used to trigger GC.Because of this new struct, some related fields and operations are removed from
ControllerCollectorContextandGCWorkScheduler.There is also an API change.
spawn_worker_threadis renamed tospawn_gc_thread. Now both GC worker threads and the GC controller thread are spawn with a context object.This PR does not change the two-phase initialisation of
GCWorkScheduler. It will be done in another PR.