Don't panic if forwarding word is not FORWARDED and add debug assertions #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some policies (such as Immix) can leave objects inplace and can reset the forwarding word while tracing (such as when Immix is out of space in its copy allocators). In such a case, we simply want to return the current object instead of attempting to read the forwarding pointer. This commit removes our faulty assumption and assertion and adds further debug assertions for a sanity check. Closes mmtk#579
wenyuzhao
approved these changes
Apr 29, 2022
qinsoon
added
the
PR-testing
|
Seems like the test timed out? Hmm. That's bizarre. |
|
I think that's because of the new weak reference tests, which makes it run longer. I will create a pull request to allow a longer timeout for the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some policies (such as Immix) can leave objects inplace and can reset
the forwarding word while tracing (such as when Immix is out of space in
its copy allocators). In such a case, we simply want to return the
current object instead of attempting to read the forwarding pointer.
This commit removes our faulty assumption and assertion and adds further
debug assertions for a sanity check.
Closes #579