Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Collection::COORDINATOR_ONLY_STW #814

Merged
merged 2 commits into from
May 15, 2023
Merged

Remove Collection::COORDINATOR_ONLY_STW #814

merged 2 commits into from
May 15, 2023

Conversation

ArberSephirotheca
Copy link
Contributor

Close #813

mmtk-core/src/vm/ChangeLog:
    * collection.rs: Remove deprecated constant 'COORDINATOR_ONLY_STW'.

@ArberSephirotheca
mmtk-core/src/vm/ChangeLog:
6be8ba0 
	* collection.rs: Remove deprecated constant 'COORDINATOR_ONLY_STW'.

Signed-off-by: Zheyuan Chen <sephirotheca17@gmail.com>
wks
wks approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wks wks added the PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead) label May 15, 2023
@k-sareen
Copy link
Collaborator

JikesRVM CI fails due to the missing dependency as well (see #816). Need to fix it here: https://github.com/mmtk/mmtk-jikesrvm/blob/master/.github/scripts/ci-setup.sh

@qinsoon
Copy link
Member

qinsoon commented May 15, 2023

JikesRVM CI fails due to the missing dependency as well (see #816). Need to fix it here: https://github.com/mmtk/mmtk-jikesrvm/blob/master/.github/scripts/ci-setup.sh

I created a PR here: mmtk/mmtk-jikesrvm#140

@k-sareen
Copy link
Collaborator

JikesRVM CI ran for 6 hrs apparently? Just re-running it to see if it times out again.

@qinsoon qinsoon merged commit 593cd04 into mmtk:master May 15, 2023
@wks wks mentioned this pull request Oct 25, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2023
@wks
Update doc comments (#1000)
59ff055 
We removed the feature for letting the coordinator call both
`stop_all_mutators` and `resume_mutators` since
#794 and
#814. The documentation should
reflect that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
PR-testing Run binding tests for the pull request (deprecated: use PR-extended-testing instead)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Scanning::COORDINATOR_ONLY_STW
4 participants
@ArberSephirotheca @k-sareen @qinsoon @wks