Disabling PrepareMutator from PlanConstraints #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plans do nothing when preparing mutators. We add a boolean flag so that we do not create the PrepareMutator work packets in the first place. We also remove the function that prepares Mutator for Immix. It is unnecessary to reset the ImmixAllocator of a mutator when preparing mutator because the mutator's ImmixAllocator is not used during GC. When a GC worker defragments the heap and promotes young objects, it uses the ImmixAllocator instances in ImmixCopyContext or ImmixHybridCopyContext.
wks
added
the
PR-testing
wenyuzhao
approved these changes
Sep 29, 2023
qinsoon
added a commit
to qinsoon/mmtk-core
that referenced
this pull request
Oct 3, 2023
Some plans do nothing when preparing mutators. We add a boolean flag so that we do not create the PrepareMutator work packets in the first place. We also remove the function that prepares Mutator for Immix. It is unnecessary to reset the ImmixAllocator of a mutator when preparing mutator because the mutator's ImmixAllocator is not used during GC. When a GC worker defragments the heap and promotes young objects, it uses the ImmixAllocator instances in ImmixCopyContext or ImmixHybridCopyContext. Fixes: mmtk#959
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plans do nothing when preparing mutators. We add a boolean flag so that we do not create the PrepareMutator work packets in the first place.
We also remove the function that prepares Mutator for Immix. It is unnecessary to reset the ImmixAllocator of a mutator when preparing mutator because the mutator's ImmixAllocator is not used during GC. When a GC worker defragments the heap and promotes young objects, it uses the ImmixAllocator instances in ImmixCopyContext or ImmixHybridCopyContext.
Fixes: #959