-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring block_for_gc #100
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
97c0964
Refactoring the code to reuse most of jl_gc_collect in block_for_gc
udesou 1f344d0
Pointing to the correct julia version
udesou 5a13d88
Merge branch 'master' into fix/refactor-block-for-gc
udesou 0266b5d
Merge branch 'master' into fix/refactor-block-for-gc
udesou 3bcf574
Merge branch 'master' into fix/refactor-block-for-gc
udesou 1fd0a33
Updating julia_version
udesou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this function just duplicates
jl_gc_collect
. Have you considered moving the function togc-common.c
, and letting Julia and MMTk each implement a different_jl_gc_collect
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that triggering GC manually in Julia is done via a call to
jl_gc_collect
(https://github.com/mmtk/julia/blob/83796a7d38878faa9afdb94ce84b6da00035b336/base/gcutils.jl#L129). For MMTk, we want that function to call intommtk_handle_user_collection_request
as it currently does. That's why I did the duplication, withjl_gc_prepare_to_collect
doing the actual preparation that is done injl_gc_collect
fromgc.c
.We could potentially reuse
jl_gc_collect
for what I'm doing by passing a different argument (eg. -1), but we'd still have the duplication - the code for Julia ingc.c
and the code for MMTk inmmtk-gc.c
.