Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get build info from mmtk-core #174

Merged
merged 6 commits into from
Aug 15, 2022
Merged

Get build info from mmtk-core #174

merged 6 commits into from
Aug 15, 2022

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Aug 10, 2022 •
edited
Loading

This PR implements ThirdPartyHeap::version() for mmtk/openjdk#14.

@qinsoon qinsoon mentioned this pull request Aug 10, 2022
Merged
@qinsoon qinsoon marked this pull request as ready for review August 11, 2022 00:56
@qinsoon qinsoon requested a review from wks August 11, 2022 00:56
wks
wks approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 688791e into mmtk:master Aug 15, 2022
@k-sareen
Copy link
Collaborator

k-sareen commented Aug 17, 2022 •
edited
Loading

I know the PR has merged already, but can I suggest adding the enabled features to the version string (or somewhere in --version) as well? For example, what I do when I copy builds is I name the build as jdk11-core_<mmtk-core git-hash>-jdk_<mmtk-openjdk git-hash>-vm_<openjdk git-hash>-<feature1>-<feature2>. It would make the builds more reproducible.

Nevermind. That's part of the mmtk-core PR. Missed it, sorry.

@caizixian caizixian mentioned this pull request Sep 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wks wks wks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinsoon @k-sareen @wks