Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MMTk core PR #817 (alternative approach) #220

Merged
merged 3 commits into from
May 26, 2023

Conversation

wks
Copy link
Contributor

@wks wks commented May 22, 2023

This is an alternative approach for #218 that addresses the upstream API change in mmtk/mmtk-core#817. This PR simply saves the mutator pointers into a VecDeque and embeds it into the iterator.

@wks wks changed the title Update mmtk core 817 alternative Update MMTk core PR #817 (alternative approach) May 22, 2023
@wks wks requested a review from qinsoon May 22, 2023 05:20
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon merged commit 52680f9 into mmtk:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants