Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the version after cd #227

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Show the version after cd #227

merged 1 commit into from
Aug 11, 2023

Conversation

wks
Copy link
Contributor

@wks wks commented Aug 11, 2023

That will show the actual used cargo version specified by rust-toolchain.

@wks
Show the version after cd
717ab32 
That will show the actual used cargo version specified by
`rust-toolchain`.
@wks wks requested a review from qinsoon August 11, 2023 06:13
k-sareen
k-sareen approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@k-sareen k-sareen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

qinsoon
qinsoon approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@qinsoon qinsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. What is the intention of this change?

@k-sareen
Copy link
Collaborator

Reporting the correct rust version being used to build the binding

@wks
Copy link
Contributor Author

wks commented Aug 11, 2023

Looks good. What is the intention of this change?

I installed multiple versions of Rust toolchains locally. When I compile OpenJDK, it shows the following:

Building target 'default (exploded-image)' in configuration 'linux-x86_64-normal-server-release'
cargo 1.71.1 (7f1d04c00 2023-07-29)
cd /home/wks/projects/mmtk-github/openjdk/../mmtk-openjdk/openjdk/../mmtk && cargo build --release --target x86_64-unknown-linux-gnu 
   Compiling mmtk v0.18.0 (/home/wks/projects/mmtk-github/parallels/feature/packet-size3/mmtk-core)
   Compiling mmtk-macros v0.18.0 (/home/wks/projects/mmtk-github/parallels/feature/packet-size3/mmtk-core/macros)
   Compiling mmtk_openjdk v0.18.0 (/home/wks/projects/mmtk-github/mmtk-openjdk/mmtk)
    Finished release [optimized] target(s) in 22.13s
Finished building target 'default (exploded-image)' in configuration 'linux-x86_64-normal-server-release'

That's very confusing. Then I found it is just printing the wrong version instead of actually using 1.71.1 to compile mmtk-openjdk.

@wks wks enabled auto-merge (squash) August 11, 2023 06:35
@wks wks merged commit 48a8277 into mmtk:master Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-sareen k-sareen k-sareen approved these changes

@qinsoon qinsoon qinsoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wks @k-sareen @qinsoon