Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating code to reflect API change #238

Merged
merged 6 commits into from
Sep 11, 2023

Conversation

udesou
Copy link
Contributor

@udesou udesou commented Sep 6, 2023

Merge after mmtk/mmtk-core#897 to reflect the API change.

mmtk/Cargo.toml Outdated Show resolved Hide resolved
@udesou
Copy link
Contributor Author

udesou commented Sep 6, 2023

@qinsoon Do you know why I'd be getting failing tests here?

@qinsoon
Copy link
Member

qinsoon commented Sep 6, 2023

@qinsoon Do you know why I'd be getting failing tests here?

It should be the mark compact issue we talked about in the meeting. You can merge master to the mmtk-core PR to include 42991c2e43f251214a1a9be2c24933f9c2339f35 in the PR, and the issue should be fixed.

@udesou udesou merged commit 24d0ca6 into mmtk:master Sep 11, 2023
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants