Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI and cargo build errors #78

Merged
merged 14 commits into from
Aug 14, 2023
Merged

Conversation

wenyuzhao
Copy link
Member

@wenyuzhao wenyuzhao commented Aug 14, 2023

  • Fix GitHub actions so it runs on ubuntu-20.04 and can pass all the v8 unit tests (with mmtk nogc). But it still pins a relatively old v8 commit.
  • Fix all the cargo build errors
  • Update rust-toolchain to match mmtk-core
  • Update mmtk-v8 version to v0.18.0

Note that v8 with mmtk-v8 still can't build on ubuntu-22.04, until we move forward the pinned v8 commit to a version that supports 22.04.

@wenyuzhao wenyuzhao requested review from qinsoon and caizixian August 14, 2023 00:02
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@qinsoon
Copy link
Member

qinsoon commented Aug 14, 2023

Thanks for the PR!

.github/scripts/build-mmtk.sh Outdated Show resolved Hide resolved
@wenyuzhao wenyuzhao merged commit 6afb834 into mmtk:master Aug 14, 2023
caizixian added a commit to mmtk/mmtk-core that referenced this pull request Aug 14, 2023
caizixian added a commit to mmtk/mmtk-core that referenced this pull request Aug 14, 2023
wenyuzhao pushed a commit to wenyuzhao/mmtk-core that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants