Minor refactoring to follow existing style #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes a few changes to follow mmtk where it deviated from the set style: - some functions for MMTK were not namespaced with `rb_mmtk_`. I updated these so it's easier to differentiate CRuby functions from MMTK ones. - fixes `if USE_MMTK` indentation in a few places - removes an empty `if USE_MMTK`
|
Thank you for your fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to follow mmtk where it deviated from the set style:
rb_mmtk_. I updated these so it's easier to differentiate CRuby functions from MMTK ones.if USE_MMTKindentation in a few placesif USE_MMTK