Fix mmtk compilation #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this is inside the `USE_MMTK` conditional, then `WHEN_USING_MMTK` macros isn't defined and building CRuby without mmtk will fail.
Fixes a warning that `rb_mmtk_is_ppp_wrapper` was not returning a value for a non-void function.
wks
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included two fixes:
Include mmtk header outside USE_MMTK
If this is inside the
USE_MMTKconditional, thenWHEN_USING_MMTKmacros isn't defined and building CRuby without mmtk will fail.
Fix return on rb_mmtk_is_ppp_wrapper
Fixes a warning that
rb_mmtk_is_ppp_wrapperwas not returning a valuefor a non-void function.