Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESP8266 and ESP32 #58

Closed
wants to merge 1 commit into from

Conversation

pauloacmartinez
Copy link

Hi! This simple ifdef solved the problem for me with pgmspace.h

@wmacevoy
Copy link
Collaborator

There is a competing pull request #57 with a very similar goal. #57 points out there are watchdog timeout issues which cause the firmware tests to fail because the tests take too long. Since yield is os-specific and somewhat orthogonal to testing framework, there is some philosophy to get right about how to fix this.

Can you look at that pull, and decide if you can incorporate the yield in a way that supports both boards. In particular, can you add a yield() after line 254 in the run() method of Test?

This will not fix all the timeout issues. The firmware tests which run long need to have a conditional yield in them as well. Having these demonstrated in the tests as explicit code I think will help devs write more correct code on these boards.

@wmacevoy
Copy link
Collaborator

By the way, if we do merge this pull, can we count on you to help support issues on these boards?

@ssilverman
Copy link
Contributor

I think it just needs to include pgmspace.h and not cores/esp8266/pgmspace.h. Also, this does not compile with PlatformIO with the board set to huzzah.

@wmacevoy
Copy link
Collaborator

v2.3.X-alpha compiles on ESP32 and ESP8266

@wmacevoy wmacevoy closed this Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants