fix: modify replaceBindings logic to fit current laravel implementation.

mnabialek · Jul 1, 2023 · b51bc46 · b51bc46
1 parent b7792f6
commit b51bc46
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Objects/Concerns/ReplacesBindings.php b/src/Objects/Concerns/ReplacesBindings.php
@@ -19,7 +19,7 @@ protected function replaceBindings($sql, array $bindings)
         $generalRegex = $this->getRegex();
 
         foreach ($this->formatBindings($bindings) as $key => $binding) {
-            $regex = is_numeric($key) ? $generalRegex : $this->getNamedParameterRegex($key);
+            $regex = is_int($key) ? $generalRegex : $this->getNamedParameterRegex($key);
             $sql = preg_replace($regex, $this->value($binding), $sql, 1);
         }
 
@@ -43,7 +43,7 @@ protected function value($value)
             return (int) $value;
         }
 
-        return is_numeric($value) ? $value : "'" . $value . "'";
+        return is_int($value) ? $value : "'" . $value . "'";
     }
 
     /**

diff --git a/tests/Objects/SqlQueryTest.php b/tests/Objects/SqlQueryTest.php
@@ -53,7 +53,7 @@ public function it_returns_valid_query_with_replaced_bindings()
 
         $expectedSql = <<<EOF
 SELECT * FROM tests WHERE a = '\'test' AND CONCAT('{$bindings[1]->toDateTimeString()}', '%'
- , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = 67.23
+ , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = '67.23'
 EOF;
 
         $this->assertSame($expectedSql, $query->get());
@@ -72,7 +72,7 @@ public function it_returns_valid_query_with_replaced_bindings_for_immutable_date
 
         $expectedSql = <<<EOF
 SELECT * FROM tests WHERE a = '\'test' AND CONCAT('{$bindings[1]->toDateTimeString()}', '%'
- , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = 67.23
+ , '{$bindings[2]->format('Y-m-d H:i:s')}') = 453 AND column = '67.23'
 EOF;
 
         $this->assertSame($expectedSql, $query->get());