Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extension of shops/places - currently only processing of detected keys.txt (+ PR to SC) are needed #12

Closed
matkoniecz opened this issue Feb 8, 2024 · 7 comments

Comments

@matkoniecz
Copy link
Contributor

See

streetcomplete/StreetComplete#5373 (comment)

streetcomplete/StreetComplete#5152 (comment)

list of relevant object got extended.

Do you want help with reviewing/classifying tags?

@mnalis
Copy link
Owner

mnalis commented Feb 9, 2024

Do you want help with reviewing/classifying tags?

Thanks for offer @matkoniecz; it would be much appreciated if you have some spare time!

There are already a few dozen TODO entries in keys.txt to move to correct category too, in addition to the comments you linked (which I need to take some time to properly understood, but won't have before next week unfortunately)

@matkoniecz matkoniecz changed the title extension of shops/places extension of shops/places - currently only club key missing (and processing of detected keys) Feb 22, 2024
@matkoniecz matkoniecz changed the title extension of shops/places - currently only club key missing (and processing of detected keys) extension of shops/places - currently only club key missing (and processing of detected keys + PR to SC) Feb 22, 2024
@mnalis
Copy link
Owner

mnalis commented Feb 22, 2024

club key encoding issue from #21 is fixed, and has added new TODOs to keys.txt

@mnalis mnalis changed the title extension of shops/places - currently only club key missing (and processing of detected keys + PR to SC) extension of shops/places - currently only processing of detected keys.txt (+ PR to SC) are needed Feb 22, 2024
@matkoniecz
Copy link
Contributor Author

Oh and if you finished processing for today - feel free to ping me, maybe I will look into it again this evening

@mnalis
Copy link
Owner

mnalis commented Feb 22, 2024

thanks @matkoniecz feel free to continue, I'm done for today

@matkoniecz
Copy link
Contributor Author

And I am also done for today and probably tomorrow...

Oh and thanks for taming that club group!

@mnalis
Copy link
Owner

mnalis commented Feb 24, 2024

done in streetcomplete/StreetComplete#5501

thanks again for all the help!

@mnalis mnalis closed this as completed Feb 24, 2024
@matkoniecz
Copy link
Contributor Author

And also thanks for help and you work on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants