street furniture overlay

[matkoniecz]

fixes #4912

[westnordost]

Regarding what should be in the overlay and what not:

StreetComplete affords to be more opinionated than iD (presets) when it comes down to which things to support displaying and adding. iD potentially has everything in the presets for which there is a clear documentation in the wiki, no disputes (and someone created a PR for that).

For StreetComplete on the other hand, the quest and overlay guidelines continue to apply. For example, storm drains (manhole=drain) would be both spammy (because there are so many) and not serve a useful purpose, maybe more. There are a couple of more things whose useful purpose (and spammyness) may be questionable, such as (from the top of my head) free-standing bollards that are not actually vertices on roads and ways.

Furthermore, certain things should be not included in the overlay that may qualify as street furniture but should rather go into an own, dedicated overlay. One example of these would be traffic_sign=*.

A feature which fulfills the StreetComplete guidelines that fits into the overlay but there is no iD preset yet, can still be added to the overlay. It may not be displayed and not be addable for now, but as soon as an iD preset is added, it would be.

[westnordost]

A preliminary review:

[matkoniecz]

Also, I have tested it while going home: and this overlay works better than I expected.

[westnordost]

Remaining TODOs:

• discuss element selection (see previous comment)
• support deleting POIs
• it should not be possible to change the type of an existing POI. Either delete it or mark it as disused (but I doubt the usefulness of that).
• "should bench icon be used on object selection? Or the same as during adding?" (I don't understand this TODO)

[matkoniecz]

"should bench icon be used on object selection? Or the same as during adding?" (I don't understand this TODO)

when you select already added object marker has bench icon

[FloEdelmann]

Currently not included are dolphin, dovecote and monitoring_station.

I'd like to see man_made = dovecote being included, I don't know much about the other two.

[matkoniecz]

+1 to taking some decision on split here

Places

It is kind of confusing for people used to place= tag in OSM, but I have no better name :(

I think I would like to have monitoring_station to be included but I may be unusually interested in them.

[westnordost]

"Places" could also be named "Shops & Amenities". But this would be slightly incorrect as it includes more and I think, the association with place only exists for OSM veterans.

Also, since "Street Furniture" does not work 100% for the things included plus more importantly, I expect it will be difficult and/or awkward to translate, I am considering just using the word "Things". And while the term "thing" is really fuzzy, everybody would agree that e.g. a "supermarket" or "restaurant" is not a "thing". But a bench is a "thing", isn't it?

So there are then Places, Things, (Structures, Roads).

[westnordost]

I'll work on this more today

[westnordost]

So what do you think about the rename to "Things"? Compared with "Street Furniture". Note the list of things that are currently included in the overlay: https://github.com/streetcomplete/StreetComplete/pull/5373/files#diff-5371d38421445449e44a28b1bccef727000adf69d46fb3ed3ae22989b888b227)

[westnordost]

"should bench icon be used on object selection? Or the same as during adding?" (I don't understand this TODO)

when you select already added object marker has bench icon

Hm, right, well, this is somewhat of a technical limitation. So, maybe use the plus icon for all? Or maybe have a white dot (inside the green circle) as an icon for the overlay?

[peternewman]

Map features like shops or amenities that usually have a name and can be entered.

To demarcate this category from others, the following are not included:

Pedant, does that mean you can't map kiosks as a shop? As an end user, you don't enter them. I can't think of a better simple wording though (apart from usually can be entered).

what is still omitted are things that are rather like landuses, such as parks, gardens, golf courses, but also marketplaces, miniature golf courses, zoos, theme parks, military bases etc.

So, some things that may be called "places" are still missing from this overlay even though they can be entered, but I found it weird to add it into this category, or what do you think?

It seems a bit of a shame we can't just drop a pin on the map to say this is here. I appreciate the footprint is probably more important with these than a building.

* **tourism=** camp_pitch, camp_site, caravan_site, picnic_site, theme_park, zoo

It seems a huge shame and rather inefficient that the camp ones (which would trigger additional SC quests) can't be added to the map from within SC.

* [ ]  it should **_not_** be possible to change the type of an existing POI. Either delete it or mark it as disused (but I doubt the usefulness of that).

It seems a bit odd I can do bench->picnic table in the quest, but not in this new overlay, or e.g. phonebox re-purposed to sharing library.

Likewise I've found disused post boxes and phoneboxes quite often. The thing is still there, but it doesn't serve its usual purpose.

So what do you think about the rename to "Things"?

It seems a reasonable compromise to me, again I can't think of a different all-encompassing name and it fits well with places.

Currently not included are dolphin, dovecote and monitoring_station.

I'd like to see man_made = dovecote being included, I don't know much about the other two.

I'm pretty certain I've seen dolphins, but didn't know they were called that.

[westnordost]

Yeah, you cannot enter a kiosk, but just like (street) food stalls that only have outdoor seating (if at all) I would still rather allocate them to places than things.

Regarding your remarks: It is unfortunate, but do you appreciate the reasoning behind that?