Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generalization across time #559

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

hoechenberger
Copy link
Member

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@hoechenberger hoechenberger force-pushed the time-generalization branch from 5517869 to f00e08f Compare May 20, 2022 13:04
@hoechenberger hoechenberger marked this pull request as ready for review May 20, 2022 13:06
@hoechenberger hoechenberger force-pushed the time-generalization branch from f00e08f to 834f5b3 Compare May 20, 2022 13:11
@agramfort
Copy link
Member

agramfort commented May 20, 2022 via email

@hoechenberger
Copy link
Member Author

I agree, I will come up with a solution.

@hoechenberger hoechenberger marked this pull request as draft May 20, 2022 16:07
@hoechenberger
Copy link
Member Author

This is now blocked by mne-tools/mne-python#10694

@hoechenberger hoechenberger force-pushed the time-generalization branch from f1e8e23 to 2e0d92e Compare June 8, 2022 12:02
@hoechenberger hoechenberger force-pushed the time-generalization branch from 2e0d92e to d7abbaf Compare June 8, 2022 12:20
@hoechenberger hoechenberger marked this pull request as ready for review June 8, 2022 13:02
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful !

@agramfort agramfort merged commit e9e1705 into mne-tools:main Jun 8, 2022
@agramfort
Copy link
Member

thx @hoechenberger !

@hoechenberger hoechenberger deleted the time-generalization branch June 8, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants