MAINT: Fix bug with overrides #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hoechenberger feel free to merge if you're happy: https://output.circle-artifacts.com/output/job/3c2180ee-d055-41ef-8eaa-c4970830e226/artifacts/0/site/index.html Should we cut a 1.0.3 once this is merged, or wait for your doc updates? |
|
Going to merge this one and we can iterate further separately. Happy to help with any rebase/merge conflicts this creates! |
|
This appears to have fixed the banner!
|
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help with #684.
Short of updating all structure since @hoechenberger is working on that, this just:
overridesso that the banner hopefully worksCommitted with
[circle ds003392]to speed up the doc build