Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using caching for get_runs_all_subjects to speed up get_runs #716

Merged
merged 7 commits into from
Feb 28, 2023

Conversation

agramfort
Copy link
Member

closes #715

@apmellot can you see if it fixes your problem?

@apmellot
Copy link
Contributor

@agramfort Yes it fixes my problem!

@hoechenberger
Copy link
Member

I didn't really take the time to look, but I expected the pkg_resources issue to be solved already upstream via mne-tools/mne-python#11454 -- maybe some bits were forgotten there?

@larsoner larsoner enabled auto-merge (squash) February 28, 2023 19:05
@larsoner
Copy link
Member

@hoechenberger downloading eeg_matchingpennies is currently at ~40 minutes and will probably time out soon. It's a ~350 MB dataset for subject 05 (the one we use) -- I'm going to just make an osf.io mirror of the dataset I think...

@agramfort
Copy link
Member Author

agramfort commented Feb 28, 2023 via email

@larsoner
Copy link
Member

I just restarted the CI

I've effectively done that a couple of times, and it didn't help. I am downloading the dataset now and it has been over 20 minutes and it's not done locally. We need to migrate I think

@agramfort
Copy link
Member Author

agramfort commented Feb 28, 2023 via email

@larsoner larsoner merged commit 1273503 into mne-tools:main Feb 28, 2023
@hoechenberger
Copy link
Member

I'm going to just make an osf.io mirror of the dataset I think...

Go for it :)

@larsoner larsoner mentioned this pull request Mar 23, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

slow down with loads of subjects due to quadratic cast of get_runs function
4 participants