Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation examples for ch_types configuration option #745

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

allermat
Copy link
Contributor

Before merging …

  • Changelog has been updated (docs/source/changes.md)

@larsoner
Copy link
Member

Can you try going to https://app.circleci.com/pipelines/github/mne-tools/mne-bids-pipeline/3751/workflows/61c987e8-e885-4433-9e0c-1e1014a8ab20 and then logging in with GitHub credentials to see if it solves the CircleCI issue? If not (or you don't want to) I can just push an empty commit on top of yours

@allermat
Copy link
Contributor Author

@larsoner I just did that, not sure how to rerun the tests?

@larsoner
Copy link
Member

You could git commit --allow-empty -m 'TST: Ping' && git push. I just asked it to rerun and it still says blocked so I'll do it...

docs/source/v1.4.md.inc Outdated Show resolved Hide resolved
@larsoner larsoner enabled auto-merge (squash) June 26, 2023 15:46
@larsoner
Copy link
Member

Looks good, pushed a commit and enabling auto-merge when green, thanks in advance @allermat !

@larsoner
Copy link
Member

No idea what's going on with CircleCI now but I'll merge and look at how it goes on main. Thanks @allermat !

@larsoner larsoner disabled auto-merge June 26, 2023 16:06
@larsoner larsoner merged commit b065da1 into mne-tools:main Jun 26, 2023
@allermat allermat deleted the issue#744fix branch June 26, 2023 16:06
@hoechenberger hoechenberger changed the title Issue#744fix Fix bug with outdated info on ch_types config option Jul 3, 2023
@hoechenberger hoechenberger changed the title Fix bug with outdated info on ch_types config option Fix documentation examples for ch_types configuration option Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants