Rename ica_ctps_ecg_threshold to ica_ecg_threshold
#935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consistency with `ica_eog_threshold` - Allows us to later add support for additional ECG-detection methods
larsoner
reviewed
Apr 23, 2024
mne_bids_pipeline/steps/preprocessing/_06a2_find_ica_artifacts.py
Outdated
Show resolved
Hide resolved
larsoner
approved these changes
Apr 23, 2024
|
Manually tested 246 and it's all good so I'll manually merge, thanks @hoechenberger ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ica_eog_thresholdBefore merging …
docs/source/changes.md)