Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

key_press_event is deprecated, needs to be replaced in our code #1068

Closed
sappelhoff opened this issue Sep 28, 2022 · 3 comments · Fixed by #1069
Closed

key_press_event is deprecated, needs to be replaced in our code #1068

sappelhoff opened this issue Sep 28, 2022 · 3 comments · Fixed by #1069
Assignees
@hoechenberger
Labels
code-health

Comments

@sappelhoff
Copy link
Member

see: https://github.com/mne-tools/mne-bids/actions/runs/3145484445/jobs/5112832235#step:14:1665
@hoechenberger
Copy link
Member

I wonder if we shouldn't just remove the Inspector (the source of the warnings) … does anyone actually use it?
I put a lot of time and energy into its creation but I feel it's kind of obsolete these days…

@hoechenberger hoechenberger self-assigned this Sep 28, 2022
@adam2392
Copy link
Member

adam2392 commented Sep 28, 2022 •
edited
Loading

If it gets integrated with the mne qt browser that would become super slick :p

hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Sep 28, 2022
@hoechenberger
Fix Inspector tests for Matplotlib 3.6 compatibility
303b143 
Fixes mne-tools#1068
@hoechenberger hoechenberger mentioned this issue Sep 28, 2022
Merged
7 tasks
hoechenberger added a commit to hoechenberger/mne-bids that referenced this issue Sep 28, 2022
@hoechenberger
Fix Inspector tests for Matplotlib 3.6 compatibility
fcbe734 
Fixes mne-tools#1068
@sappelhoff
Copy link
Member Author

I put a lot of time and energy into its creation but I feel it's kind of obsolete these days…

hurts to read this ^^

I wouldn't purge that code, I am hopeful somebody finds it useful (although I personally haven't used it yet).

sappelhoff added a commit that referenced this issue Sep 29, 2022
@hoechenberger @sappelhoff
Fix Inspector tests for Matplotlib 3.6 compatibility (#1069)
7be49cf 
* Fix Inspector tests for Matplotlib 3.6 compatibility

Fixes #1068

* fix doc issue

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoechenberger hoechenberger

Labels
code-health
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Inspector tests for Matplotlib 3.6 compatibility hoechenberger/mne-bids
3 participants
@hoechenberger @adam2392 @sappelhoff