Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename inspect module? #1366

Open
sappelhoff opened this issue Jan 14, 2025 · 2 comments
Open

Rename inspect module? #1366

sappelhoff opened this issue Jan 14, 2025 · 2 comments

Comments

@sappelhoff
Copy link
Member

cc @hoechenberger @drammock

image

WDYT?

@hoechenberger
Copy link
Member

I don't think we should rename it, honestly ... If anything, I'd consider removing it altogether, as I doubt it's ever found widespread use (I suppose @adam2392 is the only one using it 😃😃)

@drammock
Copy link
Member

I've never used inspect_dataset. It looks a little... unfinished? If removing it is seriously on the table, I'd suggest opening an issue to gather community input on the question, then in the next release notes, prominently link to that issue and ask people to weigh in if they've ever used it / would be sad if it went away. After some period of time (3 months?) assess the feedback and decide whether to deprecate. Until then, changing its name risks creating unnecessary churn / work (if its ultimate fate is removal, no reason to rename in the interim).

sappelhoff added a commit that referenced this issue Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants