Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nirs convert only auto accepted #1092

Merged
merged 3 commits into from
Nov 1, 2022
Merged

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Nov 1, 2022

PR Description

fixes https://mne.discourse.group/t/write-raw-bids-and-snirf/5843

without this fix, passing a NIRS file with a format other than "auto" to write_raw_brainvision will run into an issue at this line:

elif format not in CONVERT_FORMATS[datatype]:

with this fix, a sensible error is raised, namely: users should use format="auto" with NIRS files.

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1092 (0f170c5) into main (a552a53) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1092   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          24       24           
  Lines        3860     3861    +1     
=======================================
+ Hits         3675     3676    +1     
  Misses        185      185           
Impacted Files Coverage Δ
mne_bids/config.py 97.67% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff can I ask you to update what's new and maybe add a test?

🙏

@sappelhoff
Copy link
Member Author

@agramfort, done!

@agramfort agramfort enabled auto-merge (squash) November 1, 2022 13:11
@agramfort agramfort merged commit be17f5b into mne-tools:main Nov 1, 2022
@sappelhoff sappelhoff deleted the fixnirs branch November 1, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants