-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] FIX: Convert line_freq
and overwrite
to proper types in CLI
#1125
Conversation
@achilleasNP could you please try whether the changes here fix your problem? You can install this version using: And then uninstall ( |
Codecov Report
@@ Coverage Diff @@
## main #1125 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 40 40
Lines 8670 8676 +6
=======================================
+ Hits 8262 8268 +6
Misses 408 408
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you add a changelog entry?
@sappelhoff I just tested it and the commit fixes my problem. Thank you! |
line_freq
and overwrite
to proper types in CLIline_freq
and overwrite
to proper types in CLI
PR Description
fixes #1124
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: