Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Add defusedxml dependency to "full" variant #1218

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Jan 22, 2024

Addresses the problem we saw in #1217

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@hoechenberger hoechenberger changed the title Add defusedxml dependency to "full" variant MRG: Add defusedxml dependency to "full" variant Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af3fefb) 97.61% compared to head (0d97f5d) 97.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
- Coverage   97.61%   97.55%   -0.06%     
==========================================
  Files          40       40              
  Lines        8685     8685              
==========================================
- Hits         8478     8473       -5     
- Misses        207      212       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sappelhoff sappelhoff enabled auto-merge (squash) January 22, 2024 14:00
@sappelhoff sappelhoff merged commit 103ea3f into mne-tools:main Jan 22, 2024
17 of 18 checks passed
@hoechenberger hoechenberger deleted the fix-deps branch January 22, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants