Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit hooks, fix sphinx_gallery #1245

Merged
merged 2 commits into from
May 13, 2024

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Apr 15, 2024

@sappelhoff
Copy link
Member

@hoechenberger there seems to be a CI issue with the inspect module -- do you have an idea what could be wrong?

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from ffa024f to 29aafd1 Compare April 22, 2024 21:06
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 29aafd1 to fb95d0f Compare April 29, 2024 21:41
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.3.5 → v0.4.3](astral-sh/ruff-pre-commit@v0.3.5...v0.4.3)
@drammock
Copy link
Member

CircleCI failure is

WARNING: cannot cache unpickable configuration value: 'sphinx_gallery_conf' (because it contains a function, class, or module object)

Which should be fixed if you update sphinx gallery to have sphinx-gallery/sphinx-gallery#1289 (see the fix in MNE-Python: mne-tools/mne-python#12574)

@sappelhoff where are you seeing problem with inspect module?

@sappelhoff
Copy link
Member

@drammock I looked into this, and potentially into the nightly CI runs as well and saw the inspect module turning up red somewhere. I can't find it anymore now, so thanks for alerting me that what I thought a bug was maybe just a CI fluke (... or my imagination).

@sappelhoff sappelhoff changed the title [pre-commit.ci] pre-commit autoupdate Update pre-commit hooks, fix sphinx_gallery May 13, 2024
@hoechenberger hoechenberger merged commit 96f8dee into main May 13, 2024
30 checks passed
@hoechenberger hoechenberger deleted the pre-commit-ci-update-config branch May 13, 2024 21:01
@sappelhoff
Copy link
Member

@drammock @hoechenberger I think this is the failure that threw me off recently: https://github.com/mne-tools/mne-bids/actions/runs/9106401009/job/25033546552#step:20:1185

FAILED mne_bids/tests/test_inspect.py::test_inspect_single_file[True] - matplotlib._api.deprecation.MatplotlibDeprecationWarning: Auto-close()ing of figures upon backend switching is deprecated since 3.8 and will be removed in 3.10. To suppress this warning, explicitly call plt.close('all') first.
FAILED mne_bids/tests/test_inspect.py::test_inspect_single_file[False] - UserWarning: FigureCanvasAgg is non-interactive, and thus cannot be shown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants