Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump to 3.10 min req #1297

Merged
merged 6 commits into from
Aug 21, 2024
Merged

MAINT: Bump to 3.10 min req #1297

merged 6 commits into from
Aug 21, 2024

Conversation

larsoner
Copy link
Member

Suggested move to require 3.10+. Clean up something that could have been cleaned up once 3.9+ was required. Clean up incorrect installation versions for stable and prev-stable (which used to be the same!).

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (87eea28) to head (36835f8).
Report is 56 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
- Coverage   97.61%   97.45%   -0.17%     
==========================================
  Files          40       40              
  Lines        8685     8716      +31     
==========================================
+ Hits         8478     8494      +16     
- Misses        207      222      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Eric.

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll adjust the branch protection rules for required checks.

.github/workflows/unit_tests.yml Outdated Show resolved Hide resolved
.github/workflows/unit_tests.yml Outdated Show resolved Hide resolved
larsoner and others added 2 commits August 20, 2024 13:39
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
@larsoner
Copy link
Member Author

Okay should be good @sappelhoff !

@sappelhoff sappelhoff merged commit bed28fa into mne-tools:main Aug 21, 2024
22 of 23 checks passed
@sappelhoff
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants