Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add BIDS schema validator #1302

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

sappelhoff
Copy link
Member

PR Description

Trying to add the schema validator to our CI

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (ed75468) to head (c50032c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          40       40           
  Lines        8872     8872           
=======================================
  Hits         8648     8648           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff
Copy link
Member Author

sappelhoff commented Sep 2, 2024

Okay, so as expected, we are getting a number of failures. Will be worth looking into that and fixing it.

Most importantly:

  • [ERROR] ASSOCIATED_EMPTY_ROOM 'AssociatedEmptyRoom' field needs to point to an existing file.
  • [ERROR] ENTITY_NOT_IN_RULE Entity not listed as required or optional for files with this suffix /sub-01/ses-01/meg/sub-01_ses-01_task-testing_run-01_markers.sqd - run not in rule rules.files.raw.meg.markers
  • BTI data seemingly producing: [ERROR] NOT_INCLUDED Files with such naming scheme are not part of BIDS specification.

@sappelhoff sappelhoff marked this pull request as draft September 2, 2024 20:16
@sappelhoff sappelhoff added this to the 0.16 milestone Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant