Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning given if no events are written and task is resting state #1327

Merged
merged 13 commits into from
Oct 22, 2024

Conversation

skjerns
Copy link
Contributor

@skjerns skjerns commented Oct 22, 2024

PR Description

There was a warning given when write_raw_bids(...) when no events were provided. This was a simple mistake in if logic. Replacing the or with and fixed this.

I don't think that a test is necessary for this minor bug

resolves #1324

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (c1d59ec) to head (4889ff8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          40       40           
  Lines        8876     8876           
=======================================
  Hits         8652     8652           
  Misses        224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sappelhoff sappelhoff merged commit fba8609 into mne-tools:main Oct 22, 2024
23 checks passed
@sappelhoff
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning given for missing events, even if task=='rest'
2 participants