ENH : add support for landmarks as dict in write_anat and kind param … #955
Conversation
…in get_head_mri_trans
agramfort
requested review from
hoechenberger and
sappelhoff
and removed request for
hoechenberger
There was a problem hiding this comment.
LGTM in principle, and seems okay from a BIDS point of view (https://bids-specification.readthedocs.io/en/latest/04-modality-specific-files/02-magnetoencephalography.html).
I am missing a changelog entry, and maybe (optional) some example.
Codecov Report
@@ Coverage Diff @@
## main #955 +/- ##
==========================================
+ Coverage 94.40% 94.51% +0.10%
==========================================
Files 25 25
Lines 3559 3573 +14
==========================================
+ Hits 3360 3377 +17
+ Misses 199 196 -3
Continue to review full report at Codecov.
|
| if isinstance(landmarks, (str, Path)): | ||
| landmarks, coord_frame = read_fiducials(landmarks) | ||
| landmarks = np.array([landmark['r'] for landmark in |
There was a problem hiding this comment.
It seems we're missing a test for this code path
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
|
@hoechenberger this one is good to go from my end |
|
Thanks @agramfort |
…in get_head_mri_trans
this is to be able to have landmarks eg for different sessions for coregistration