-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH, MRG] Simplify reading dig #979
Conversation
After this, the plan is to do similar restructuring for write and add both read and write to the example. Modifying write is a bit trickier because sometimes we use a different space (usually |
Codecov Report
@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 94.72% 94.88% +0.15%
==========================================
Files 25 25
Lines 3698 3675 -23
==========================================
- Hits 3503 3487 -16
+ Misses 195 188 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah much better. I like it.
Co-authored-by: Adam Li <adam2392@gmail.com>
@adam2392 @alexrockhill |
IMO, I would prefer to get it done before the release, maybe we can have @timonmerk @moritz-gerster test |
Alright, let's merge then once all is green! |
Thanks @alexrockhill! |
Okay, this is the penultimate PR from #973. This simplifies the reading logic for digitizations to give a consistent warning for all templates. It also allows 'unknown' to be set as the coordinate frame for MEG data, which technically should be allowable because template coordinate frames are acceptable for MEG too. It gets rid of most of the specific references to 'Other' in reading which is my favorite part because that really shouldn't be a part of BIDS.
Merge checklist
Maintainer, please confirm the following before merging: