Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT, MRG] remove voxels from example #988

Merged
merged 2 commits into from
Mar 22, 2022
Merged

Conversation

alexrockhill
Copy link
Contributor

@alexrockhill alexrockhill commented Mar 22, 2022

bids-standard/bids-specification#1031 specifies that template data should be in scanner RAS so we should remove the voxel example and clarify that surface RAS == scanner RAS for fsaverage.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #988 (dffd887) into main (d717ea7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #988   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files          25       25           
  Lines        3713     3713           
=======================================
  Hits         3530     3530           
  Misses        183      183           
Impacted Files Coverage Δ
mne_bids/dig.py 98.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d717ea7...dffd887. Read the comment docs.

@agramfort agramfort merged commit 71130fc into mne-tools:main Mar 22, 2022
@agramfort
Copy link
Member

thx @alexrockhill !

@alexrockhill alexrockhill deleted the ex branch March 22, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants