Add default ICA decomposition and default method #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we could fit a sensible ICA if None is provided. This PR is a draft where I chose to use
picard
. I also added a default to themethod
argument inlabel_components
. The idea is to be able to do:Personally, I'm -1 for this change. I prefer to leave the responsibility of getting an ICA (and hopefully a good one) in the hand of the user. Adding the possibility to 'auto-fit' an ICA makes
label_components
messier, since it now has to also output the ICA decomposition to which the labels relate to.@adam2392 WDYT?