Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default ICA decomposition and default method #40

Closed
wants to merge 3 commits into from

Conversation

mscheltienne
Copy link
Member

As discussed, we could fit a sensible ICA if None is provided. This PR is a draft where I chose to use picard. I also added a default to the method argument in label_components. The idea is to be able to do:

from mne_icalabel import label_components

labels, ica = label_components(raw)

Personally, I'm -1 for this change. I prefer to leave the responsibility of getting an ICA (and hopefully a good one) in the hand of the user. Adding the possibility to 'auto-fit' an ICA makes label_components messier, since it now has to also output the ICA decomposition to which the labels relate to.

@adam2392 WDYT?

@jacobf18
Copy link
Collaborator

jacobf18 commented May 8, 2022

I am also in favor of leaving the ICA to the user. However, I think we should be clear that EEGLAB uses extended infomax for ICA. I have not tested the performance of ICLabel on different types of ICA methods, but I think it should be able to work on any type

@mscheltienne
Copy link
Member Author

Good point! It should, but we should probably issue a warning if the ICA decomposition provided does not use an extended infomax.

@hoechenberger
Copy link
Member

hoechenberger commented May 8, 2022

Note that picard will produce the same results as extended infomax if the following parameters are passed:

ortho=False, extended=True

@adam2392
Copy link
Member

adam2392 commented May 8, 2022

+1 for keeping current workflow and making users run ICA themselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants