Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MNE-Python 1.0.0 stable #105

Merged
merged 3 commits into from
Mar 21, 2022
Merged

Use MNE-Python 1.0.0 stable #105

merged 3 commits into from
Mar 21, 2022

Conversation

hoechenberger
Copy link
Member

cc @larsoner

Will fail until the new packages are on the CDN

@hoechenberger hoechenberger changed the title Use MNE 1.0.0 stable Use MNE-Python 1.0.0 stable Mar 21, 2022
@larsoner
Copy link
Member

FYI I've put this in step 17 in #105

@larsoner
Copy link
Member

@larsoner
Copy link
Member

@hoechenberger I say we merge this once green so that we have some working installers, then update the URLs on the homepage to use them. That takes away any time pressure from release.

Then we merge conda-forge/mne-feedstock#88, rebuild in another PR here, and iterate until they work on all platforms. Once they do, we can update the installer pages again. WDYT?

@hoechenberger
Copy link
Member Author

Yes +100 for me

@hoechenberger
Copy link
Member Author

I'm off for the rest of the day, do what you think is best. We'll send out the announcement tomorow, right? @agramfort

@larsoner larsoner merged commit 8ce139c into main Mar 21, 2022
@larsoner larsoner deleted the rel-1.0 branch March 21, 2022 18:10
@larsoner
Copy link
Member

I tested the draft pre10 on all three platforms and things appeared to work, so I cut a new v1.0.0 non-draft, non-prerelease version (+tag). Once the assets show up, I'll update the installation instructions with [circle deploy] for both. Then I think things will be all set for release announcements (I edited the google doc @agramfort) tomorrow

@hoechenberger
Copy link
Member Author

Amazing. Thanks so much @larsoner

I'm also feeling comfortable with tuning and improving the installer whenever an idea or an issue pops up. In the worst case, users can always go back to using our conda install instructions if the installer doesn't work in their system until we provide a fix.

@drammock drammock mentioned this pull request Oct 11, 2022
48 tasks
@drammock drammock mentioned this pull request Dec 20, 2022
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants