Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump to 1.0.2 #118

Merged
merged 8 commits into from
Apr 15, 2022
Merged

MAINT: Bump to 1.0.2 #118

merged 8 commits into from
Apr 15, 2022

Conversation

larsoner
Copy link
Member

Will fail until conda-forge/mne-feedstock#93 lands and then hits CDNs later today

@larsoner
Copy link
Member Author

Okay good now it failed, which it should (no way 1.0.2_0 has hit CDNs yet). I found the bug only because it succeeded the first time incorrectly!

@larsoner
Copy link
Member Author

@hoechenberger FYI I think I have a test almost working, will push...

@@ -196,6 +196,29 @@ jobs:
run: |
.\MNE-Python-%MNE_INSTALLER_VERSION%-Windows.exe /S /InstallationType=JustMe /AddToPath=1

- name: Export frozen environment definition (macOS)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole block is verbatim copy-paste just to make sure the .json is available before the testing blocks

@larsoner
Copy link
Member Author

Got it!:

AssertionError: mne: got '1.0.1_0' != want '1.0.2_0'

Now let's see if it's fixed when I set the version properly in the version spec (and if the content is on the CDNs)

@larsoner
Copy link
Member Author

@hoechenberger ready for review/merge from my end

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow this is amazing!!

@hoechenberger hoechenberger merged commit c073828 into mne-tools:main Apr 15, 2022
@larsoner larsoner deleted the 102 branch April 15, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants